Python versions tested now 2.7-3.6

okfn / messytables

Tools for parsing messy tabular data. This is now superseded by https://github.com/frictionlessdata/tabulator-py

http://messytables.readthedocs.io/

387 stars 110 forks source link

Python versions tested now 2.7-3.6 #182

Closed davidread closed 5 years ago

davidread commented 5 years ago

Test support for python up to 3.6.
Not going to python 3.7, due to weird test failure - for someone to tackle in another PR
Drop testing for python 2.6, since 2 is going soon anyway.

davidread commented 5 years ago

Curious error with python 3.7 only - maybe xlrd is not compatible?

======================================================================
FAIL: test_attempt_read_encrypted_no_password_xls (test.test_read.ReadXlsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/okfn/messytables/messytables/excel.py", line 47, in get_workbook
    formatting_info=with_formatting_info)
xlrd.biffh.XLRDError: Workbook is encrypted

davidread commented 5 years ago

@StevenMaude could you review/merge please?

davidread commented 5 years ago

@pudo perhaps you could review/merge this please?

StevenMaude commented 5 years ago

NB: I don't have write access to this repo any longer to merge, but looks fine to me if the tests pass.