type_guess guesses datetime field on xls files as string - Githubissues

okfn / messytables

Tools for parsing messy tabular data. This is now superseded by https://github.com/frictionlessdata/tabulator-py

http://messytables.readthedocs.io/

387 stars 110 forks source link

type_guess guesses datetime field on xls files as string #30

Closed nigelbabu closed 11 years ago

nigelbabu commented 11 years ago

See https://gist.github.com/4502515 for the test cases, https://github.com/okfn/messytables/blob/master/horror/simple.xls is the xls file, and https://github.com/okfn/messytables/blob/master/horror/simple.csv is the csv file used.

Both when running messytest2.py with latest messytables or messytest1.py with 0.3.0 (when DateType worked albeit slowly), it returns

[String, Integer, String]

However, when I run messytest3.py (which runs type_guess on simple.csv) it correctly returns the following

[DateUtil, Integer, String]

domoritz commented 11 years ago

You probably added guess_types to https://gist.github.com/nigelbabu/4502515#file-messytest2-py-L11, right?

nigelbabu commented 11 years ago

Indeed, sorry about that.