search

okfn / opendataday

Open Data Day website
http://opendataday.org
Creative Commons Zero v1.0 Universal
86 stars 112 forks source link

Removed de_at from lektorproject #258

Closed loleg closed 4 years ago

loleg commented 4 years ago

Corrects the build blocking issue #257 to complete #256

Local build works fine.

loleg commented 3 years ago

@StephenAbbott you reverted this change. Why? I thought we agreed last year that dialects were superfluous. The Austrian translation is also not being maintained and shows the wrong themes etc.

If I caused the confusion by not cleaning out all the relevant translation files in this PR, then my apologies.

chris48s commented 3 years ago

I suspect this got reverted because only removing the item from lektorproject but leaving in the list of languages ( https://github.com/okfn/opendataday/blob/master/databags/languages.json ) probably left us with a broken link in the menu and reverting this "fixed" it.

@StephenAbbott - can you confirm we're good to remove this and I'll clean out all the de_at content (I'm doing some work on the site at the moment anyway)

StephenAbbott commented 3 years ago

Thanks @chris48s. From memory, I think you're right. Happy for you to do the necessary to remove the de_at translation

StephenAbbott commented 3 years ago

And thanks @loleg for flagging

chris48s commented 3 years ago

Fully removed in https://github.com/okfn/opendataday/commit/f93e30b65c346288cf5b39b0756b9cb8b0f75754

loleg commented 3 years ago

Thanks both!