search

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
183 stars 22 forks source link

Make editors take 100% of height #235

Closed roll closed 6 months ago

roll commented 1 year ago

Overview

See vertical grey lines taking only part of the screen

editor

guergana commented 7 months ago

I have taken this as my first issue and the first thing that I realized is that there is a big need to give class names to all the MUI components. It is very very hard to debug even with the React Dev Tools because the class names there are auto generated and we have many different components, nested ones, etc...

I will suggest using the BEM naming convention but also open to suggestions :)

I also think naming everything <Box> and <Grid> is already made the code very hard to maintain, we should have some wrapper elements. For this PR I will just so class names, we would probably need a ticket for refactoring and creating the wrapper elements.