Recover development flow (tests/CI); remove `lxml` dependency (via `pyquery`)

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.

http://opendataeditor.okfn.org

MIT License

164 stars 19 forks source link

Recover development flow (tests/CI); remove `lxml` dependency (via `pyquery`) #312

Closed roll closed 5 months ago

roll commented 5 months ago

fixes tests/CI
fixes #303

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying opendataeditor with Cloudflare Pages

Latest commit:	`deca91b`
Status:	✅ Deploy successful!
Preview URL:	https://d2c7be53.opendataeditor.pages.dev
Branch Preview URL:	https://303-remove-lxml-dependency.opendataeditor.pages.dev

View logs

roll commented 5 months ago

Hey @pdelboca @romicolman Aside from the CI/tests fixes needed for recovering development flow, this PRs remove pyquery dependency that causes lxml installation from #303. In general, the lxml dependency is very slow to install, and it seems to it just doesn't work on some MacOS versions (it can't be fixed on our side). So we can just drop tabular HTML format support for now as it's actually never been documented and does not really have any UI support. Moreover, HTML has never been mentioned during the User Research phase as a tabular format.