okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
164 stars 19 forks source link

Change message when deleting a file #315

Closed romicolman closed 5 months ago

romicolman commented 5 months ago

Problem description

When you want to delete a file you get this message:

Captura de pantalla 2024-04-11 a la(s) 13 00 08

Steps to reproduce it

Suggested solution

Replace (icon) Cancel (ESC) and (icon) Delete (Enter) with this:

Are you sure you want to delete this file? Options: CANCEL/ OK

guergana commented 5 months ago

Hello, @romicolman Do you explicitly want to have the name of the file removed from the message? Or is this only an oversight or an example of the text above the buttons? I have replaced the button messages but not sure about replacing You are deleting <NAME OF THE FILE>. Are you sure? with Are you sure you want to delete this file?. Could you please confirm which will be the final text in this part?

I am guessing "Change message" refers to the whole content of the popup and not only the content of the buttons 😅 I think it's safer if the name of the file is still part of the popup message because the user might have made a mistake when choosing which file to delete.

The message is the same when deleting a folder as well. Is there a task for that one as well?