315 - Change message when deleting

okfn / opendataeditor

No-code application to explore and publish all kinds of data: datasets, tables, charts, maps, stories, and more. Forever free and open source project powered by open standards and generative AI.

http://opendataeditor.okfn.org

MIT License

150 stars 18 forks source link

315 - Change message when deleting #320

Closed pdelboca closed 2 months ago

pdelboca commented 2 months ago

Fixes #315

cloudflare-pages[bot] commented 2 months ago

Deploying opendataeditor with Cloudflare Pages

Latest commit:	`7572a0e`
Status:	✅ Deploy successful!
Preview URL:	https://10e2f719.opendataeditor.pages.dev
Branch Preview URL:	https://315-change-message-when-dele.opendataeditor.pages.dev

View logs

pdelboca commented 2 months ago

@romicolman I have some questions regarding this one. Currently we have a coherent design of < Icon + Text + [Key] > in our design so I have two questions:

Are we planning on removing the Icon part in all buttons? Or just in these ones?
Are we planning on removing the [Key] part in all buttons? Or just in these ones?

I don't want to loose the coherence of the style. Maybe we should pause the style changes until we have the UX report?

roll commented 2 months ago

@romicolman BTW why would we remove keyboard shortcut documentation?

I don't want to loose the coherence of the style. Maybe we should pause the style changes until we have the UX report?

I forgot to mention it in the planning, but above is exactly what I wanted to say. Currently, all the dialogs are designed consistently regarding:

colors
button placements
keyboard shortcuts

There is also a complete color-coding (like blue is action, green is good, yellow is warning etc) and keyboard shortcut system (for almost all the actions and dialogs) across the whole application.

I would suggest changing it coherently, and I think it's better to do so based on User Testing sessions and after the UX-person learns the current system.

romicolman commented 2 months ago

@pdelboca / @roll Yes! I would like to avoid extra noise for the user (icon + key), but let's do this. I'll create a separate issue to check with the UX specialist before we implement changes to the ODE.

For colors, button placements and keyboard shortcuts I'll also ask Lucas to work closely to the UX person so we can adapt branding of the ODE if necessary.