okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
164 stars 19 forks source link

Editor button #346

Closed romicolman closed 4 months ago

romicolman commented 5 months ago

Problem description

When a user upload a tabular file and the table is selected, ODE shows the EDITOR button at the top. When clicking on it, nothing happens.

Captura de pantalla 2024-04-24 a la(s) 14 31 26

Steps to reproduce it

Suggested solution

Remove the Editor button.

@roll Does the button have any function?

roll commented 5 months ago

@romicolman For tables editing mode is always activated (so the button indicates it by color) but for other formats, it is modal selector

romicolman commented 5 months ago

Ok, thanks! @pdelboca we can remove the Editor button since for the stable release we will concentrate on tabular data.

guergana commented 4 months ago

Ok, thanks! @pdelboca we can remove the Editor button since for the stable release we will concentrate on tabular data.

@romicolman , should I remove the Editor button only from the Tabular data menu? I tried with a text file and a json file and the editor is always enabled as well. Should I remove this button from everywhere or only for the menu that shows with tabular data?

Image

romicolman commented 4 months ago

@guergana please, remove it from the Tabular data menu. According to @roll this button is always active whenever the user uploads tabular data in any format, so it makes no sense.

romicolman commented 4 months ago

@guergana , as we discussed during the standup meeting, please remove the Editor indicator from the app.

guergana commented 4 months ago

@guergana , as we discussed during the standup meeting, please remove the Editor indicator from the app.

Hi, I just found out the Editor button is working as a button when the file type is a chart. Should I leave the button on this case? Chart file example attached. chart.json

romicolman commented 4 months ago

@guergana when the Editor button is in purple, it is just and indicator (it does not have a particular function), so please, remove it

romicolman commented 4 months ago

Please, remove the button for chart.json