okfn / opendataeditor

No-code application to explore and publish all kinds of data: datasets, tables, charts, maps, stories, and more. Forever free and open source project powered by open standards and generative AI.
http://opendataeditor.okfn.org
MIT License
150 stars 18 forks source link

Revert button - Function? #347

Open romicolman opened 2 months ago

romicolman commented 2 months ago

Problem description

Revert button functionality is not clear.

Captura de pantalla 2024-04-24 a la(s) 15 31 25

Steps to reproduce it

Suggested solution

If the user already has the UNDO button at the top, there is no need for an extra button at the bottom of the table.

@roll Does this button has any other relevant function?

roll commented 2 months ago

@romicolman UNDO/REDO and SAVE/REVERT are on different levels of functionality.

Here is an example:

romicolman commented 2 months ago

Thanks for clarifying @roll!

romicolman commented 1 month ago

@pdelboca please, remove the REVERT button.

roll commented 1 month ago

@pdelboca please, remove the REVERT button.

Deassigned myself as it seems to be for Patricio

roll commented 1 month ago

revert

Note, that without the "Revert" button, it's impossible to change the file without saving it (so any change became undiscardable)

romicolman commented 1 month ago

@pdelboca I'm moving this issue to Sprint 3 so you can take a look at the technical implications of removing the REVERT button.

How the ODE should work. The user:

Makes a change/changes to a specific file. Click on Save ----All changes are saved.

If the user wants to undo changes, the ODE offers two options:

When the user now clicks on Quit ODE, the app should ask the user: "Do you want to save changes?" Yes/No

Open to suggestions here, @pdelboca.