Source button

[romicolman]

Problem description

I uploaded an xls and clicked on the SOURCE button and nothing happens. I saw that the button works on csv files. Does it have a particular function for xls files? I checked documentation and found this.

Image

[roll]

We need to disable the "Source" button for all the formats that doesn't make sense to be textually explored (cc @guergana)

[guergana]

What is the source button supposed to do? I think we need an explicit list with all the formats for which this button is active. @roll

[roll]

@guergana https://opendataeditor.okfn.org/documentation/working-with-tables/#source-view

I think we need an explicit list with all the formats for which this button is active.

I agree, we can start from a small subset

[roll]

On the user stories level of description, the source view helps to localize and see tabular errors usually in CSV. When as a USER I can see the error in native representation it's easier for me to fix it in the original file (actually it might make sense to allow fixing it in the source view itself if it's not yet supported)

[guergana]

@guergana https://opendataeditor.okfn.org/documentation/working-with-tables/#source-view

I think we need an explicit list with all the formats for which this button is active.

I agree, we can start from a small subset

The subset you suggest is this one from the link @roll ? csv, xls, json, parquet, html

[roll]

@guergana parquet and xls are binary or "half-binary" formats. We can start from CSV, JSON, YAML, MD I think

[romicolman]

@guergana let me know if you need further assistance from my side with this issue

[guergana]

@guergana let me know if you need further assistance from my side with this issue

Hi @romicolman @roll I am looking into this and I see the button is active for the .csv file but it is not showing me any preview. The screen changes size but I don't see the preview anywhere. I think we need to fix first the preview at least for the formats where it is supposed to work and then disable it where it is not supposed to work. Could someone show me an example of the source button working?

[roll]

@guergana https://opendataeditor.okfn.org/documentation/working-with-tables/#source-view

[romicolman]

@guergana: here is an example (for me the preview with a csv works OK)

• Open the ODE
• Upload this csv
• Click on Source. You will see this screen:

[romicolman]

Hi @roll and @guergana! I was testing another thing and I saw the that Source button is still enable on the application. However, the issue is closed. Can you check this?

[roll]

Can you please share a screenshot?

[romicolman]

As we agreed during our call, we will keep the SOURCE button for csv files. We think it adds value to users. However, we need to check if we keep the name of the button or if we change it. @Faithkenny I'm adding you here to review this.