search

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
183 stars 23 forks source link

pip timeout during initialisation in a corporate/public sector environment with HTTP proxy #359

Closed toothstone closed 4 months ago

toothstone commented 6 months ago

Tested on Windows with version 1.0.0

Probably due to an enforced HTTP proxy initialisation fails with a pip HTTP timeout message for all dependencies (can't copy paste the error message from the pop up window). ODE probably needs to make use of the system proxy settings.

romicolman commented 6 months ago

Hi @toothstone! Thanks for reporting this :) Guergana, I think this is the issue you were working on last week. It's issue #294

toothstone commented 6 months ago

I had a look at #294 but at least from the outside it seems unrelated - just to be clear: my initialisation never finishes, ODE just aborts and closes after I close the error message pop up window.

romicolman commented 6 months ago

@roll can you take a look at it?

romicolman commented 6 months ago

@guergana feel free to take a look at this issue, too

guergana commented 6 months ago

Tested on Windows with version 1.0.0

Probably due to an enforced HTTP proxy initialisation fails with a pip HTTP timeout message for all dependencies (can't copy paste the error message from the pop up window). ODE probably needs to make use of the system proxy settings.

@toothstone could you please provide more context? Did you install the APP binaries (.exe file) and got the error? did you get a popup or how was this error notified to you? or are you trying to install the project for development and saw this error in the terminal? How exactly did you get this error so I can try to reproduce it? Thanks

toothstone commented 6 months ago

@guergana Sure, here some more context/steps to reproduce:

  1. Got the official exe from the github release, https://github.com/okfn/opendataeditor/releases/download/v1.0.0/opendataeditor-win-1.0.0.exe
  2. Started it, finished installation
  3. Upon first start, it shows this for a long time: grafik
  4. Finally, I get this error message: grafik

I suspect that is due to my proxy settings, if ODE is not honoring those it is probably not able to connect to PIP etc. My proxy settings at that time look like this (URLs etc redacted, can't switch language, sorry...): grafik

I can't share the proxy script, but the default outcome is a return "PROXY some.proxy.url:80"; statement.

romicolman commented 6 months ago

Thank you @toothstone! @roll I think it's best if you take this issue. It's more complex than expected

guergana commented 6 months ago

@roll this might be helpful https://stackoverflow.com/questions/30992717/proxy-awareness-with-pip

roll commented 6 months ago

Thanks! I'm taking this one

roll commented 4 months ago

@pdelboca @guergana Let's wait to see if bundling Python works out. Is so the issue will be resolved but it's still not clear what to do with the rest remote calls that happens on the server (fetch remote file can be easily moved to Electron's main process though - https://www.electronjs.org/docs/latest/api/net; but there are also CKAN/OpenAI calls etc)