Enable multi-cell selection for deleting content of cells

okfn / opendataeditor

No-code application to explore and publish all kinds of data: datasets, tables, charts, maps, stories, and more. Forever free and open source project powered by open standards and generative AI.

http://opendataeditor.okfn.org

MIT License

150 stars 18 forks source link

Enable multi-cell selection for deleting content of cells #390

Closed guergana closed 1 month ago

guergana commented 1 month ago

fixes #350

cloudflare-pages[bot] commented 1 month ago

Deploying opendataeditor with Cloudflare Pages

Latest commit:	`21e2579`
Status:	✅ Deploy successful!
Preview URL:	https://a4205b81.opendataeditor.pages.dev
Branch Preview URL:	https://350-select-multiple-cells.opendataeditor.pages.dev

View logs

roll commented 1 month ago

@guergana I think I found the problem. Take a look at saveEditing action. Note, that we never change the grid values directly. What we do is:

add a change to the history
initiate grid reloading
- grid calls loader
- loader gets data from the server
- loader applies changes from the history
- grid gets a new data that is patched

The same flow needs to be used in deleteMultipleCells

guergana commented 1 month ago

@guergana I think I found the problem. Take a look at saveEditing action. Note, that we never change the grid values directly. What we do is:
* add a change to the history

* initiate grid reloading

  * grid calls loader
  * loader gets data from the server
  * loader applies changes from the history
  * grid gets a new data that is **patched**
The same flow needs to be used in deleteMultipleCells

Done, thanks!