Do not display Grid View button in metadata panels

[guergana]

• fixes #393

[guergana]

We might need to remove the 'Grid View' button altogether in the future if we no longer need it. I would suggest we don't remove it for now because this button is used in other panels/sections in the application.

@romicolman The grid view button exists in other parts of the application as well. Do we want to remove this button from everywhere? For example, if you upload a chart. You can use the file attached to this comment... you see again the button in the metadata panels Channels, Transforms and Layers. Same for when you upload a datapackage. You can also find a data package attached to this message. I know we are centering now on tabular data but since all the app is connected it is better to know the details because the code will be different if we remove it only in tables or everywhere.

chart.json datapackage.json

[romicolman]

Hi @guergana! First question. Is it possible to hide the button instead of removing it? Question for @pdelboca: Is the grid view useful for technical users like CKAN publishers when working on json files? For non-technical users the grid view does not add any value.

[guergana]

Hi @guergana! First question. Is it possible to hide the button instead of removing it? Question for @pdelboca: Is the grid view useful for technical users like CKAN publishers when working on json files? For non-technical users the grid view does not add any value.

@romicolman yes. Right now on the code I pushed I am only hiding it for tabular data. We can merge this and discuss if we need the Grid view Button at all later on if it's needed. I just wanted to bring it up since the button doesn't look very useful in the other panels either in my opinion 🙈

[pdelboca]

@romicolman @guergana my opinion is that Grid View is the kind of feature that do not provide greater value and makes the code unnecessarily more complex. (Since we are reusing components we need to either play around with CSS or create more hierarchies to handle the scenario.)

The list view is clear enough, and I don't understand the value that provides switching between them. Yes I guess we could fix it to display the information better but I'm in favor of less features, less UIs and less code.

Current List View vs Grid View:

[guergana]

@romicolman @guergana my opinion is that Grid View is the kind of feature that do not provide greater value and makes the code unnecessarily more complex. (Since we are reusing components we need to either play around with CSS or create more hierarchies to handle the scenario.)

The list view is clear enough, and I don't understand the value that provides switching between them. Yes I guess we could fix it to display the information better but I'm in favor of less features, less UIs and less code.

Current List View vs Grid View:

Yep. I would also remove it from the whole application. Hence my question.

[romicolman]

Yes, please, remove the grid view from the app.

[cloudflare-pages[bot]]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	099d6d3
Status:	✅  Deploy successful!
Preview URL:	https://b40e3a1b.opendataeditor.pages.dev
Branch Preview URL:	https://393-remove-grid-view-button.opendataeditor.pages.dev

View logs

[roll]

As we discussed with Romina the Grid View is useful for tabular data having many columns

[guergana]

As we discussed with Romina the Grid View is useful for tabular data having many columns

Hi, I am confused. The grid view is a button in the metadata sections like "contributors", " licenses" etc. how is this related to the amount of columns?

I have removed the grid view Button because I thought this is what the last instructions said @romicolman could you please clarify? :)

[guergana]

Yes, please, remove the grid view from the app.

@roll this is the last comment from the last discussion

[romicolman]

Please, remove grid view from all metadata fields.

Thanks!

[guergana]

@roll @pdelboca this is ready for a final review. :)

[pdelboca]

@guergana could you as well remove the onGridClick attribute from the Editors and isGrid from the states?

This code will be orphan since it is only triggered by the button we are removing :)

[guergana]

@guergana could you as well remove the onGridClick attribute from the Editors and isGrid from the states?

This code will be orphan since it is only triggered by the button we are removing :)

Good catch! That was an oversight. Will remove it.