okfn / opendataeditor

No-code application to explore and publish all kinds of data: datasets, tables, charts, maps, stories, and more. Forever free and open source project powered by open standards and generative AI.
http://opendataeditor.okfn.org
MIT License
149 stars 18 forks source link

Proof of Concept - testing Desktop menu options #412

Closed guergana closed 3 weeks ago

guergana commented 1 month ago

This PR is for testing out how customizable the desktop app menu is for different platforms. Not to be merged.

Findings:

cloudflare-pages[bot] commented 1 month ago

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4aaadb
Status: ✅  Deploy successful!
Preview URL: https://6853ff9d.opendataeditor.pages.dev
Branch Preview URL: https://392-top-menu-options.opendataeditor.pages.dev

View logs

guergana commented 1 month ago

@romicolman could you please make a build for Mac and test that the menu is showing? The options in the menu should be the ones I added in this file: https://github.com/okfn/opendataeditor/pull/412/files#diff-1802e03bbe8980e8dc3f41469c27831fc21b679efeb9534ab23c9a783671aba4 :D

romicolman commented 1 month ago

@guergana I checked changes on Mac. The Open Data Editor menu seems ok, but I can't see other changes. I also have a couple of comments: VIEW menu Toggle developer tools.: Is this useful for developers? This is the first time I see this option on a View menu. Toggle full screen: can we change it to Full screen?

Open Data Editor menu Services: can we remove this option?

HELP menu

We should include the Open Data Editor User Guide there: https://opendataeditor.okfn.org/documentation/getting-started/

FILE Menu

Captura de pantalla 2024-05-29 a la(s) 10 21 49 a  m

VIEW menu

Captura de pantalla 2024-05-29 a la(s) 10 22 44 a  m

HELP menu

Captura de pantalla 2024-05-29 a la(s) 10 22 53 a  m

Open Data Editor menu

Captura de pantalla 2024-05-29 a la(s) 10 21 32 a  m
romicolman commented 1 month ago

Based on the research, I will create a separate ticket so we can make changes to menu options.

guergana commented 4 weeks ago

Another finding of the investigation is that there are predefined actions that a menu can do, the ones that offer a more native experience, those are defined here: https://www.electronjs.org/docs/latest/api/menu-item#roles

For other actions that might not have a role, a custom action can be implemented. @romicolman

romicolman commented 4 weeks ago

Now that research is concluded, I have created a separate issue: #417

guergana commented 3 weeks ago

Closed because this was a research task and will continue in another issue. See: https://github.com/okfn/opendataeditor/pull/412#issuecomment-2144703747