search

okfn / opendataeditor

No-code application to explore and publish all kinds of data: datasets, tables, charts, maps, stories, and more. Forever free and open source project powered by open standards and generative AI.
http://opendataeditor.okfn.org
MIT License
149 stars 18 forks source link

Improve datagrid to help the user read errors - Research #429

Open romicolman opened 2 weeks ago

romicolman commented 2 weeks ago

Problem description

Right now, when the ODE previews the table, the app only indicates row numbers.

Captura de pantalla 2024-06-17 a la(s) 10 51 46 a  m

However, the error report will include the cell location to help the user identify errors. Therefore, we need to incorporate a table header, like the one Datawrapper, for example, has:

Captura de pantalla 2024-06-17 a la(s) 10 57 42 a  m

Is this possible?

Faithkenny commented 2 weeks ago

I really like Datawrapper's approach to solving this problem. I'd use it as a starting point

guergana commented 1 week ago

Hello @romicolman , I have added the column headers and it seems to be working fine, so I think the conclusion is that it can be done 💯 ✨ and we can keep this one for the complete version. You can see in the PR #436 . This PR does not include updating the error reports, though. This PR is only adding the headers. Should we create another issue for updating the error reports to identify the cells by column letter and number, since this is only the research part?

guergana commented 1 week ago

Hey @romicolman I was just thinking of what happens when there are more than 26 columns ... My example only covers the letters of the alphabet.

Will the column after Z be 'A1' or 'AA' ? Do we have maximum amount of columns that the app supports?

romicolman commented 1 week ago

Heyyy! Thanks for all the info.

Let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. Since this is a research ticket, I'll create a new one and mention this issue.

Errors report: yes...we need to update that. We are working on it.