search

okfn / opendataeditor

No-code application to explore and publish all kinds of data: datasets, tables, charts, maps, stories, and more. Forever free and open source project powered by open standards and generative AI.
http://opendataeditor.okfn.org
MIT License
149 stars 18 forks source link

Add additional header row with letters #436

Open guergana opened 1 week ago

guergana commented 1 week ago
cloudflare-pages[bot] commented 1 week ago

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 14b249c
Status: ✅  Deploy successful!
Preview URL: https://14f6e2f6.opendataeditor.pages.dev
Branch Preview URL: https://429-add-letters-header.opendataeditor.pages.dev

View logs

pdelboca commented 1 week ago

@guergana we will need to find a way to do AA, AB, AC, AD when having more columns than the alphabet of letters:

image

guergana commented 1 week ago

@guergana we will need to find a way to do AA, AB, AC, AD when having more columns than the alphabet of letters:

image

Thanks for the heads up @pdelboca , I have already wrote a comment to @romicolman to ask what the format will be. But this PR covers the research part I think. :) we could either close this PR and make a new task with the complete changes or maybe continue the task on this PR?

To me the format A1, B1 looks more intuitive than AA. But I am not very aware of how this works in other programs. How does excel do it?

romicolman commented 1 week ago

Hi! I created a new ticket to request changes (#441) but we can use this PR for the implementation.

If possible, let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. In this sense, since we use numbers for rows, in the error report we can be more specific: errors in cells AA1, B53, etc.

guergana commented 1 week ago

Hi! I created a new ticket to request changes (#441) but we can use this PR for the implementation.

If possible, let's keep the same logic that we see in Google Sheets, Excel: A-Z and then 'AA', 'AB', 'AC', 'AD'. In this sense, since we use numbers for rows, in the error report we can be more specific: errors in cells AA1, B53, etc.

Ok..thanks for the clarification. :)

romicolman commented 1 week ago

@pdelboca this is the PR where we need to check Frictionless to see to what extent we can tailor the errors report: https://framework.frictionlessdata.io/docs/errors/resource.html

guergana commented 1 week ago

Can be tested with the attached file. CSV_Data_2024_6_24 22 25 many columns.csv

Or you can generate one here: https://markbdsouza.github.io/csv-data-generator/

romicolman commented 15 hours ago

Hi! I used the cvs shared in this PR and other csvs to test the change on Mac. It works OK. @pdelboca Can you check it in Windows?