Open pdelboca opened 4 days ago
Latest commit: |
98b45fc
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ffaf0c97.opendataeditor.pages.dev |
Branch Preview URL: | https://use-pyinstaller.opendataeditor.pages.dev |
Hello, @pdelboca I am testing this in Ubuntu with the file generated in the distribution files in the PR, and while I dont get any errors when opening the app after installation without access to the Internet, I can't open any files in the app:
This is what i see, the files/folders I try to add are not displayed either on the left menu or the right content panel.
I can't make a local build because I am missing some dependencies. I have run make install
and afterwards make build
and got these errors:
opendataeditorgutz@C306:~/Desktop/Things/opendataeditor/opendataeditor$ make build
hatch run build
[assets] Copying 'desktop/assets' to 'build'
[server] Creating executable file for FastAPI server
246 WARNING: Failed to collect submodules for 'frictionless.vendors.wkt' because importing 'frictionless.vendors.wkt' raised: ModuleNotFoundError: No module named 'grako'
46563 WARNING: Hidden import "pysqlite2" not found!
46564 WARNING: Hidden import "MySQLdb" not found!
Traceback (most recent call last):
File "/home/gutz/.local/share/hatch/env/virtual/.pythons/3.10/python/lib/python3.10/runpy.py", line 196, in _run_module_as_main
return _run_code(code, main_globals, None,
I have googled the issue and I have found a couple links like this one and this one suggesting to change pysqlite2
to sqlite3
to remove the Hidden import "MySQLdb" not found!
warning I had to go through the following steps
sudo apt-get -y install clang
MySQLdb
from here: https://github.com/PyMySQL/mysqlclient/blob/main/README.md#linux
I couldn't finish this step because of an error with the clang command: clang error unknown target cpu 'x86-64-v3'
. I found an explanation to the issue but I couldn't make it work because the version of clang that gets installed is version 10, and to install clang-12
or clang-13
, one needs to install it as a separate package and it's still not picked up by the other installer that expects the package to be clang. So I also failed to build it manually for my particular cpu version.
The version from the PR artifacts installs well in Windows 10 inside VirtualBox and works fine.
Given that the results for Windows and Ubuntu were very different, we should test this as well natively in MacOS, can we organize a call for this @romicolman ? :pray: (We test it together and we make some comments for Patricio based in our findings)
This PR refactors the application to use PyInstaller to handle the backend FastAPI server when building the application.
Main Changes:
runServer
logic to only one function and one module.Updates Python to 3.11 (required for PyInstaller)
TODO:
loading.html
splash screen do not work properly since we need to migrate the logic of waiting to the server from the main application to the launch script. This will be better to do in #445 .