okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
160 stars 19 forks source link

Changes to the datagrid #520

Closed romicolman closed 4 days ago

romicolman commented 3 weeks ago

Description

For further context, please check issue #485

Figma file section for datagrid here.

Changes to the datagrid

This issue is to implement changes to the datagrid. Please, take into consideration that in other tickets we removed/hide the following buttons from the datagrid:

In these implementation we will keep these features:

and the buttons Publish and Save changes.

This is how it should look like:

Image

List of changes and instructions

Other things to consider

romicolman commented 2 weeks ago

@guergana There is an extra issue that you will need to consider when working on the implementation of the new datagrid:

Because of the implementation of the sidebar, the metadata panel and the Errors report (currently named Report) have moved:

Image

Image

Faithkenny commented 2 weeks ago

@romicolman here, @guergana should be using OKFN/Red/400 from our color palette

Other things to consider

  • In the current version of the ODE, the app highlights in red cells with errors. We need to keep that indication. @Faithkenny are we keeping the same color here? Does Guergana need to use a different red variation?
  • @guergana: when the user clicks on METADATA this panel should be displayed (we won't change that logic. Keep it as it is). Same for the ERRORS REPORT functionality.
Faithkenny commented 2 weeks ago

@romicolman There's a design opportunity here. I will share it with you on Slack

  • Change the name of the REPORT button to ERRORS REPORT: if the file has 0 errors, that button should be grey. @Faithkenny what should be the color of this button if the file contains errors?
Faithkenny commented 1 week ago

Implementation guidelines for the Errors report button,

Please see the Variants/States here

image

Here's the Figma file, and Prototype

https://github.com/user-attachments/assets/765ff449-7993-4c1c-a23f-3433c3f4a1bf