search

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
163 stars 19 forks source link

348 do not cast values when editing the Grid #538

Closed pdelboca closed 3 weeks ago

pdelboca commented 3 weeks ago

This is a tiny step towards making the experience of editing a little bit more intuitive.

Currently, we have this isolated line of code that forces the user input to be converted to an integer if the cell is "number". This causes the famous NaN that confused some users.

I'm removing this from the front-end to move towards a more freely experience of editing the data.

Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

guergana commented 3 weeks ago

Hi, @pdelboca now it doesn't show the NaN but the cell is left blank. I guess this is the purpose of the PR.

pdelboca commented 3 weeks ago

Indeed @guergana ! Thanks!