search

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
163 stars 19 forks source link

Modify cell editing styles #551

Closed guergana closed 1 week ago

guergana commented 1 week ago
cloudflare-workers-and-pages[bot] commented 1 week ago

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: af608ac
Status: ✅  Deploy successful!
Preview URL: https://081e1e71.opendataeditor.pages.dev
Branch Preview URL: https://540-change-style.opendataeditor.pages.dev

View logs

romicolman commented 1 week ago

@guergana I have just checked changes.

I selected a file from the the left menu, but I don't see all style aligned to Faith's comment here.

Here is a video

https://github.com/user-attachments/assets/45927a51-51f7-42a8-aa8e-c4ef0c67c2d7

On the other hand, @roll this is a question for you. I tried to edit a the following cell (Extra cell error) and it is not possible. Do you know why?

https://github.com/user-attachments/assets/0ad4a953-6110-4cdf-be94-62404157dc35

guergana commented 1 week ago

@guergana I have just checked changes.

I selected a file from the the left menu, but I don't see all style aligned to Faith's comment here.

  • Cell border should be thinner once the user clicks to edit the cell.
  • I do not see step 5 from Faith's comment implemented (light blue border and grey color on the background).

Here is a video

https://github.com/user-attachments/assets/45927a51-51f7-42a8-aa8e-c4ef0c67c2d7

On the other hand, @roll this is a question for you. I tried to edit a the following cell (Extra cell error) and it is not possible. Do you know why?

https://github.com/user-attachments/assets/0ad4a953-6110-4cdf-be94-62404157dc35

Hello @romicolman you can't see the error because it's fixed...

I know something from the design is missing. It's not easy to implement.

roll commented 1 week ago

On the other hand, @roll this is a question for you. I tried to edit a the following cell (Extra cell error) and it is not possible. Do you know why?

Because the user can only delete an extra cell, as it's a virtual cell not-existed in the database