search

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.
http://opendataeditor.okfn.org
MIT License
183 stars 22 forks source link

Adapt dialogs to new design #556

Closed guergana closed 4 weeks ago

guergana commented 1 month ago

To avoid making this PR larger than it is, I will create another PR to address the hover colors of buttons across the app and the dialogs, and another PR speficically for the 'Publish' dialog.

cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6933754
Status: ✅  Deploy successful!
Preview URL: https://f55b616f.opendataeditor.pages.dev
Branch Preview URL: https://526-adapt-dialogs.opendataeditor.pages.dev

View logs

guergana commented 1 month ago

Thanks!

Looks good in general!

The disabled state looks quite weird for me. Is it intended?

ode

Also, just a note, that some text font/Cancel font would probably fail accessibility tests

@Faithkenny I can't find the design for the disabled state of the buttons. It needs to have a higher contrast as @roll suggests... could you point me to the design? :pray:

Faithkenny commented 1 month ago

Hey folks, Thank you for pointing that out. I've updated the foreground color (text), now it passess the accessibility checker. @roll. Consequently updates on the:

Here's the button @guergana:

image

guergana commented 1 month ago

Hey folks, Thank you for pointing that out. I've updated the foreground color (text), now it passess the accessibility checker. @roll. Consequently updates on the:

  • Add external file modal
  • Create folder modal

Here's the button @guergana:

image

@Faithkenny thanks!