Add hover states for buttons

okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.

http://opendataeditor.okfn.org

MIT License

183 stars 23 forks source link

Add hover states for buttons #620

Closed guergana closed 1 week ago

guergana commented 3 weeks ago

fixes #596

Hover states done:

Upload your data sidebar :heavy_check_mark:
Upload your data empty screen :heavy_check_mark:
Create folder Dialog :heavy_check_mark:
Publish Dialog :heavy_check_mark:
File Upload Dialog - Add External Data Tab :heavy_check_mark:
Launch Screen (aka Welcome Banner) :heavy_check_mark:
How the ODE saves your data :heavy_check_mark:
Publish button upper right bar (missing design) :heavy_check_mark:
Unsaved changes :heavy_check_mark:
Rename file/folder dialog :heavy_check_mark:
Delete dialog :heavy_check_mark:

cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying opendataeditor with Cloudflare Pages

Latest commit:	`f044384`
Status:	✅ Deploy successful!
Preview URL:	https://9f4aae10.opendataeditor.pages.dev
Branch Preview URL:	https://596-hover-states.opendataeditor.pages.dev

View logs

roll commented 2 weeks ago

Hi, looks good!

A few things I spotted:

The hover border doesn't seem to be from the palette:

hover

Publish button looks to be in the wrong place:

publish

Not related to this PR I think but the "Unsaved Changes" dialog is really unclear:

changes

Cancel the action or cancel the changes? Usually, in this context cancel means don't do anything and get me back (not discard)

guergana commented 2 weeks ago

Hi, looks good!

A few things I spotted:

The hover border doesn't seem to be from the palette:

Publish button looks to be in the wrong place:

Not related to this PR I think but the "Unsaved Changes" dialog is really unclear:

Cancel the action or cancel the changes? Usually, in this context cancel means don't do anything and get me back (not discard)

Hi @roll I have addressed your comments except the one from the cancel. What is your suggestion? To have the text say "discard" instead of cancel? We wanted to have a standard cancel action for all buttons, this is why we changed the discard text to have all say "cancel" but you are right, in this case is confusing. This should be discussed with @romicolman and @Faithkenny .

romicolman commented 1 week ago

Hi! I have just checked all comments. Please, do not change the Cancel button for Discard. However, let's make the text clearer:

Replace

There are unsaved changes.

For

There are unsaved changes. Please, click save or cancel.

roll commented 1 week ago

Please, click save or cancel

Cancel action or changes?

romicolman commented 1 week ago

Hi! Actions can be broad for users. Please @guergana let's procede with the text I suggested until we finish the user testing session. I'll inform you both if users mention find the change confusing.