okfn / opendataeditor

The Open Data Editor (ODE) is a no-code application to explore, validate and publish data in a simple way. Forever free and open source project powered by the Frictionless Framework.

http://opendataeditor.okfn.org

MIT License

184 stars 23 forks source link

Dont accept invalid characters in Metadata Resource name #625

Closed guergana closed 2 weeks ago

guergana commented 3 weeks ago

fixes #618

cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying opendataeditor with Cloudflare Pages

Latest commit:	`f168b63`
Status:	✅ Deploy successful!
Preview URL:	https://07314be2.opendataeditor.pages.dev
Branch Preview URL:	https://618-invalid-characters.opendataeditor.pages.dev

View logs

guergana commented 2 weeks ago

Hi, I tested it,

It does the trick but obviously it's kind a hack so the real solution would be having something like isResourceErrored state after #494

So what is your suggestion? We merge this for now and then create the solution you suggest when we work on #494 ?

roll commented 2 weeks ago

494 will anyway change how things work so I guess it's fine for now to keep it as it is