Some comments made during review are not recorded

[autofunk]

Summary: some reviewers have encountered issues with text in the comments section not being correctly saved on some occasions (not always).

As this is hard to track down if you do have a problem please report here with the full text that you were trying to submit.

We are working as fast as possible to fix this

Info

From Rayna Stamboliyska:

I'm the MENA Editor and am having recurrent issues with recording information in the 'Comments' section. This has happened nearly all the time I'm trying to save my review, e.g. for Tunisia.

To cut it short: I write my comment, then enter my name and push "Publish". The page loads, I'm sent to the country's page with all indicators, but when I hover over the "i" icon, I still see the old text.

This has happened many times today, and every time I have to start over "Submit revisions", then click on "Review", then on "Publish", but it doesn't change anything. Issue is the same when I clear cache log in again and resume.

I am not sure what this is due to, nor how I should proceed because as I never know when my modifications will be taken into account :(

Thanks much in advance for input and solutions :) Rayna

[mattfullerton]

This seems related to #121, which has perhaps not solved the problem. And if it hasn't solved the problem, we need to reopen #180 and implement the solution proposed there which is to add a warning to the flash messages.

[jpmckinney]

It would seem that I'm facing the same issue (can't update comments).

[mattfullerton]

Just to clarify, are the other fields updating properly (and instantly?) if so then that's much easier to investigate

[jpmckinney]

Steps to reproduce:

• Click "Propose Revisions"
• Change the comment field and submit
• Click "Review Now"
• Witness that the comment is changed
• Submit

Yet, the overview page still has the old comment.

[mattfullerton]

OK, I've just attempted to reproduce this and can't. The only problem I see is that new lines are getting stripped out when we fill the "propose revisions" form (which shouldn't be happening...). We'll deploy the current code to the live site shortly and then see if its a problem specific to the deployed site/spreadsheet.

[jpmckinney]

Did you attempt in production or development? Could there be an issue if the comment is quite long?

[mattfullerton]

Yep, you found it. If its very long it doesn't get updated. OK, now we have something to go on. I tested in development, and found this in development now too.

[dibyanta]

I'm having the same problem while updating the Indonesian Gov Spending section. Although the rest of the contents were updated, the comments and details section displayed the old version. I did have a long comment since I'm trying to justify the review and to provide alternative links to access the data. So what should I do?

[mattfullerton]

Hi - right at this moment in time, the best thing to do is to try and keep the information short. If possible, referring to external resources. Hopefully we will fix this problem today or tomorrow.

You can also send me the details section directly and I will try and insert it manually.

Best, Matt

On 8 October 2013 14:44, dibyanta notifications@github.com wrote:

I'm having the same problem while updating the Indonesian Gov Spending section. Although the rest of the contents were updated, the comments and details section displayed the old version. I did have a long comment since I'm trying to justify the review and to provide alternative links to access the data. So what should I do?

— Reply to this email directly or view it on GitHubhttps://github.com/okfn/opendatacensus/issues/194#issuecomment-25886191 .

[dibyanta]

Hi, I've cut down to an even shorter version than the previous comments but it still wouldn't update. I would greatly appreciate if you could insert them for me.

Long version: It is unknown whether such a database currently exist. The Ministry of Finance of the Republic of Indonesia had planned to implement the SPAN (Sistem Perbendaharaan dan Anggaran Negara/State Treasury and Budget System) in 2013, but it has been delayed. The SPAN is meant to be an internal integrated system of all processes related to the management of the budget, including budget preparation, budget document management, procurement management, payment management, revenue management, cash management, and reporting. Before, such transactional-level data seem to be scattered among individual line ministries instead of being in a unified database. Whether such detailed data is considered 'public' is unknown.

A much more aggregated realized spending report, however, is available for download in PDF form from http://www.depkeu.go.id/indekskatalogdata/559 (quarterly report) or ftp://ftp1.perbendaharaan.go.id/produk/dia/lkpp/ (annual report).

A database of nationwide government awarded contracts is also available at the LKPP LPSE e-Procurement portal http://inaproc.lkpp.go.id/.

Shortened version: The implementation of SPAN (State Treasury and Budget System) has been delayed. Before, such data seem to be scattered among the individual ministries. More aggregated reports are available at http://bit.ly/1a7tgXx (quarterly) or http://bit.ly/nQUCJi (annual). A database of government awarded contracts is also available at http://inaproc.lkpp.go.id/.

Thanks a bunch!

[mattfullerton]

To reproduce: Go to 2013 production site Go to Indonesia page Submit revisions for Indonesia Government Spending, paste in the long version of the text above Back on Indonesia page, click on Review Changes At this point we've lost line breaks (separate problem), but the full text should be there. In the text box paste in the text again, with line breaks. Click Publish. The text does not get published. Probably unrelated but this entry has "Data Exists"=Unsure

[mattfullerton]

This happens when the current entries have new lines in them.

[mattfullerton]

This should now be fixed. To give a fuller explanation, the problem was occurring when updates were attempted on any entry that had line breaks in the details field, [tech: because of insufficient regex matching in the library that rewrites the XML from Google Spreadsheets].

I have updated the Indonesia/Spending entry, anyone else who has had problems is encouraged to go back and check affected entries. We're very sorry for this oversight on our part and many thanks for helping us track this down.

[dibyanta]

Thanks Matt. Was just wondering though, since previously I failed to update the shortened version as well which didn't contain new lines. But nevermind if it works perfectly now. Thanks!

[mattfullerton]

The problem was only if the /original/ entry had new lines, which in this case it did(?).

Am 09.10.2013 um 16:36 schrieb Alika Tuwo notifications@github.com:

Thanks Matt. Was just wondering though, since previously I failed to update the shortened version as well which didn't contain new lines. But nevermind if it works perfectly now. Thanks!

— Reply to this email directly or view it on GitHub.