search

okfn / opendefinition

Open Definition source
https://opendefinition.org/
Creative Commons Attribution 4.0 International
109 stars 123 forks source link

Open Buttons do not pass colour contrast accessibility #81

Open stevensimon opened 9 years ago

stevensimon commented 9 years ago

http://opendefinition.org/buttons/

The "blue" and orange/grey buttons do not pass WCAG 2.0 colour contrast minimums. Please see improved versions attached (sorry, I'd submit a pull request but I can't find where these images are in a repo, only on the assets server of okfn...)

oc_80x15_blue oc_80x23_blue od_80x15_blue od_80x23_blue ok_80x15_blue ok_80x15_orange_grey ok_80x23_blue os_80x15_blue os_80x15_orange_grey

mlinksva commented 9 years ago

Thanks for this. I don't know if there's a public repo for the OK assets server. I'll try bringing this issue to attention of sysadmins who have resolved previous issues with the site.

nigelbabu commented 9 years ago

These buttons are hosted on S3, but version controlled on this bitbucket repo. If you can submit a pull request there, we can accept it and do the sync. Does that sound okay?

stevensimon commented 9 years ago

That sounds ok :) Will do so soonish! Noticed a few other buttons that may need tweaking so will add them in as well. Thanks for informing me of the bitbucket repo

rufuspollock commented 9 years ago

@stevensimon how are you doing on the pull requests. I'm also wondering whether we move those specific buttons here ... (i.e. to this repo)

stevensimon commented 8 years ago

@rgrp I never got around to using the bitbucket repo unfortunately... my employment finished up early this year and I lost all access to my old email (bitbucket creds were in there) and honestly, have been out of the industry since. I don't mind doing the rest of the buttons up, shouldn't take too long. I'll leave it up to you whether to move them into this repo or you can add them into the bitbucket repo yourself :)