search

okfn / timeliner

[DEPRECATED] See new TimeMapper repo https://github.com/okfn/timemapper
https://github.com/okfn/timemapper
93 stars 21 forks source link

Links open in new window #40

Closed agm3dc closed 11 years ago

agm3dc commented 11 years ago

Since opening a link means losing your place in the timeline, it would be fantastic if links opened in new windows. Thanks again for the awesome tool.

djw commented 11 years ago

Are there any links on the view page that we don't want to open in new windows? If not, it's trivial to add

<base target="_blank" />

to the page head.

agm3dc commented 11 years ago

I think it ALWAYS makes sense to open in new window. I'm virtually code illiterate so not sure that answers your question.... thx for your help.

rufuspollock commented 11 years ago

@djw I think all links within the part of the page that would be embedded (i.e. timeline, map, footer) should open in a remote window but those in the navbar i'm not sure about ...

I think we could just try and see if that causes any problems ...

agm3dc commented 11 years ago

We've been putting links in the descriptions, which is what I was referring to. Here's an example: September 2, 2011

NDI and World Bank Institute launch global PMO report

NDI and WBI launch "Strengthening Parliamentary Accountability, Citizen Engagement and Access to Information: A Global Survey of Parliamentary Monitoring Organizations." The report identifies nearly 200 parliamentary monitoring organizations (PMOs) around the world. http://bit.ly/17oVyyu

http://www.openingparliament.org/about

djw commented 11 years ago

@rgrp On the view page, I can't see any links which aren't present in the embed. If there are any links we want to open in the same window we can explicitly state target=_self.