search

okfn / timeliner

[DEPRECATED] See new TimeMapper repo https://github.com/okfn/timemapper
https://github.com/okfn/timemapper
93 stars 21 forks source link

Search breaks timeline view #42

Open djw opened 11 years ago

djw commented 11 years ago

I believe this is because timeline has an idea of its currently-selected slide, and this doesn't get cleared when we update the dataset. So in effect you might be asking for e.g. slide 4 of 2.

abbasmousavi commented 11 years ago

I have the same problem. some times when searching, timeline view breaks (disappears)

I get this error: (this problem also exists in medieval philosophers example on site) the map view works fine

var _pos = slides[current_slide].leftpos(); TypeError: slides[current_slide] is undefined timeline.js (line 3175)

abbasmousavi commented 11 years ago

@rgrp can you please take a look at this issue?

rufuspollock commented 11 years ago

@abbasmousavi we know what the issue is and will be fixing but it is pending on whether we want search as filter or search as find .... For the present I'm going to hide the search.

djw commented 11 years ago

This is really a recline issue, so I've opened a ticket there (okfn/recline#347). I'll keep this ticket open for the timeliner-specific UI issues.