search

okfn / timeliner

[DEPRECATED] See new TimeMapper repo https://github.com/okfn/timemapper
https://github.com/okfn/timemapper
93 stars 21 forks source link

Bugs in BC date display #54

Closed atomrab closed 11 years ago

atomrab commented 11 years ago

In testing a google doc with a series of BC dates in [-500] format, I see two problems: 1) my earliest entry doesn't appear (not sure if this is limitation in range of BC dates, since earliest is 10000-8000 BC, or if the first entry is just knocked off); and 2) the flags that pop up over the map markers are all off by one entry: that is, when you move the timeline forward one entry, the label for the previous record appears (there is no flag for the entry with which the timeline begins when loaded)

See http://timeliner.okfnlabs.org/view/?url=https%3A%2F%2Fdocs.google.com%2Fspreadsheet%2Fccc%3Fkey%3D0AopTd0iC1n9GdHltTkxJa2xTUHdMOF84NGduUWxaOFE%26usp%3Ddrive

I should add that the marker is also off when you click any item on the timeline below, not just when you move from entry to entry in the main window:

image

rufuspollock commented 11 years ago

@atomrab thanks - will get this fixed - sounds like 2 issues are related.

rufuspollock commented 11 years ago

OK, it seems there isn't a bug in the main library AFAICT. After playing with your data everything works fine if I delete the oldest entry Körtik ... Still investigating ...

rufuspollock commented 11 years ago

As stated issues with out of step is due to missing first item. Missing first item seems to be due to date of <= -10000. E.g. this forked spreadsheet with -9999 works fine: https://docs.google.com/a/okfn.org/spreadsheet/ccc?key=0AqR8dXc6Ji4JdERlaFAzTTA0ZTlsTXVlLWs5bzNpSlE#gid=0 - see timeline version

Note also that with bad date it is only missing in the timeline not in the map.

My guess is an issue in timelinejs with dates prior to 10000 BC but I need to confirm this with more work.

rufuspollock commented 11 years ago

OK, so tracked remaining issue to fact that timelinejs does not support BC dates <= 10000. i.e.

VMM.Date.parse(-10000) => Invalid Date
VMM.Date.parse(-9999) => OK
rufuspollock commented 11 years ago

Looks like this got fixed in v2.25 of timelinejs so fix arriving soon!

rufuspollock commented 11 years ago

@atomrab this is now working fine for me with dates <= 10k BC - see e.g. the copy of your timeline which I've now added an even earlier date to - plus your timeline looks to be working fine!

atomrab commented 11 years ago

Perfect -- thanks! Just in time for the semester. Expect some traffic from UT Austin pretty soon!