search

okfn / timemapper

Create and share elegant timelines and timemaps fast
http://timemapper.okfnlabs.org/
MIT License
273 stars 60 forks source link

New style spreadsheet urls with no gid failing #139

Closed rufuspollock closed 10 years ago

rufuspollock commented 10 years ago

Urls like this with no gid:

https://docs.google.com/a/okfn.org/spreadsheets/d/1M2lRaxPtMUb4-eNHH3cgkuDhsUldhCHnu60Zrc1gNM4/edit

Fail at the moment.

Whilst this works fine:

https://docs.google.com/a/okfn.org/spreadsheets/d/1M2lRaxPtMUb4-eNHH3cgkuDhsUldhCHnu60Zrc1gNM4/edit#gid=0

this is because recline.backend.gdocs does not auto-guess gid (this was intentional as when new-style sheets came out originally it seems gid for new spreadsheets was a random integer and hence unguessable ...)

rufuspollock commented 10 years ago

FIXED: https://github.com/okfn/recline.backend.gdocs/commit/f32758f9a4ba59bf7afa89f197a4fac7ca5d8bcd