search

okfn / timemapper

Create and share elegant timelines and timemaps fast
http://timemapper.okfnlabs.org/
MIT License
274 stars 60 forks source link

[bug] recline dep in master does not exist in recline master #160

Open rufuspollock opened 10 years ago

rufuspollock commented 10 years ago

@hychen I think you've updated the submodule dependency on recline to 7287a1b594bce81db53e4732545097c12e5da624 but that does not seem to existing in recline repo master. Is this a version of recline with extra fixes from you? If so let's get it into recline master :-)

I'm going to revert to old recline dep for the time being as that recline dep breaks heroku deploy (since heroku can't find the submodule dep).

hychen commented 10 years ago

yes, I did some experimental modification on recline for custom map setting support, timeline tag support on github.com/hychen/recline.

I need to add test case so we could merge it back to recline master.

Best regards, Hsin Yi Chen

More about me: http://about.me/hychen

2014-08-10 20:56 GMT+08:00 Rufus Pollock notifications@github.com:

@hychen https://github.com/hychen I think you've updated the submodule dependency on recline to 7287a1b594bce81db53e4732545097c12e5da624 but that does not seem to existing in recline repo master. Is this a version of recline with extra fixes from you? If so let's get it into recline master :-)

— Reply to this email directly or view it on GitHub https://github.com/okfn/timemapper/issues/160.

rufuspollock commented 10 years ago

@hychen ok - would love to see this in. Even if you open a "WIP" pull request on recline (i.e. one you'll add to) that would be useful to see what you plan :-)