Add a delay so AJAX-heavy websites are fully rendered

okfn / webshot

A web service to take screenshots

http://webshot.okfnlabs.org/

Other

21 stars 13 forks source link

Closed simong closed 10 years ago

simong commented 10 years ago

This PR adds a 2 second delay so AJAX heavy websites are loaded before we take a screenshot

rufuspollock commented 10 years ago

@simong should we make this an option rather than a default? wdyt?

rufuspollock commented 10 years ago

@simong see comment above - definitely want to get this in :-)

andylolz commented 10 years ago

+1 to making it an option.

andylolz commented 10 years ago

Sorry – I totes just jumped in and had a go!

How does this look to you, @simong? (Ace work on webshot, btw!)

simong commented 10 years ago

LGTM, thanks!

simong commented 10 years ago

I added an extra commit that makes it so you have to specify the delay in ms and adds an increment to the input field of 100

andylolz commented 10 years ago

That sounds great. I don’t see that commit though… Is it pushed?

simong commented 10 years ago

Hu odd, I could've sworn I pushed it to master. I don't have access to my personal laptop, so I'll have to push it tonight. Apologies.

andylolz commented 10 years ago

Cool, no problem!