okfn / webshot

A web service to take screenshots
http://webshot.okfnlabs.org/
Other
21 stars 13 forks source link

Error on openspending.org #14

Closed rufuspollock closed 10 years ago

rufuspollock commented 10 years ago

This seems to error: http://webshot.okfnlabs.org/api/generate?url=https://openspending.org/

@simong Any idea why?

simong commented 10 years ago

On first look it looks like an SSL error, I'll dig a bit deeper tonight why (maybe phantomjs uses it's own outdated cacert files)

2013-12-03T16:03:00 [DEBUG] WebPage - updateLoadingProgress: 10 
2013-12-03T16:03:00 [DEBUG] Network - Resource request error: 6 ( "SSL handshake failed" ) URL: "https://openspending.org/" 
2013-12-03T16:03:00 [DEBUG] WebPage - updateLoadingProgress: 100 
rufuspollock commented 10 years ago

@simong really useful. What's odd is e.g. https://okfn.org/ works fine.

Aside: i also wonder if we should dump errors to the screen atm (this is an alpha stage tool so not the end of the world to have debug info there)

rufuspollock commented 10 years ago

@simong ping re above - any thoughts ...

simong commented 10 years ago

I looked into this over the weekend and I haven't gotten much further. :(

Using the --ignore-ssl-errors=true flag doesn't seem to help at all. I'll try to compile it to a more recent version of openssl later this evening.

simong commented 10 years ago

We're now specifying the following flags:

We don't really care if the endpoint is SSL protected or claiming to be who they are so we can be a bit more relaxed about it.

I've pushed a fix to master and deployed it to webshot.okfnlabs.org

simong commented 10 years ago

For posterity's sake, the commit can be found at https://github.com/okfn/webshot/commit/c5d0ca84f67fb233b0ee4fc118216f86c52d4f73