Add an index page with a simple form on it

okfn / webshot

A web service to take screenshots

http://webshot.okfnlabs.org/

Other

21 stars 13 forks source link

Add an index page with a simple form on it #6

Closed simong closed 11 years ago

simong commented 11 years ago

This PR adds the simple functionality of showing an index page with a simple form on it from where you can generate screenshots.

I've refactored quite a bit of the original code. The following happened:

Switched from flatiron to express, as this seems to be better inline with other okfn apps
Created an /api/generate endpoint, which takes the same parameters as the old ones
Removed the imagemagick node module, as we can get away with just specifying the window size options in the webshot module.
Removed the union module as it was not used

You can run the app by running: node app

and browsing to http://localhost:5000

rufuspollock commented 11 years ago

@simong we really want to get this PR in as super-useful :-) Are you happy to update the PR to remove all the node_modules commits (alternatively we can close this PR and you can open a new one ...)

rufuspollock commented 11 years ago

@simong anything blocking you here? Would love to get this merged and this is a huge improvement that you've done here :-)

simong commented 11 years ago

Nothing is blocking me here :) I moved house over the weekend and hadn't had a chance to follow-up. I'll try to follow-up tonight and get it deployed asap.

rufuspollock commented 11 years ago

@simong no problem :-) If you want any help let me know - this is awesome :-) (I'm already regularly using it!)

simong commented 11 years ago

I rebased the commit and took everything out. I might need to tweak the Procfile a little bit when I deploy, but I figure that out as I go along. This is ready for review.

rufuspollock commented 11 years ago

@simong Looks good from the basic review - merging now :-)

simong commented 11 years ago

I've deployed this at http://webshot.okfnlabs.org