search

okgreece / Alignment

Alignment, a collaborative, system aided, user driven ontology/vocabulary matching and validation platform.
https://alignment.okfn.gr
MIT License
12 stars 1 forks source link

Switch to Protocol relatives Urls for assets, links instead of absolute paths in Alignment #38

Closed schmaluk closed 7 years ago

schmaluk commented 7 years ago

In order to serve the Alignment app also via https it might be good, if the URLs of the assets (css, js and other links) are at least protocol relative instead of absolute paths. https://www.paulirish.com/2010/the-protocol-relative-url/

skarampatakis commented 7 years ago

Relative paths are used already, utilizing the asset() helper function, which constructs the correct link based on the requested scheme. I have tested it locally with Apache and it works out of the box as you can see below.

image

Perhaps this is an issue with proxy as discussed here

I have checked and there is no X-Forwarded-Proto header on the response header so maybe that's the issue.

Maybe this helps.

skarampatakis commented 7 years ago

Any update on this?

schmaluk commented 7 years ago

Not yet. Sorry.

skarampatakis commented 7 years ago

You have not tested or it is not working?

schmaluk commented 7 years ago

I have tested it already but without the CSS, JS-links working. I tried to pass the request via http to apache from nginx. Probably I need to enable https for the apache and pass the request to apache via https from nginx.

skarampatakis commented 7 years ago

OK, please inform on any update. This seems not to be related with the app but with the server configuration as I can not reproduce it.