okhayat / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Noto Lint Tool - Way to Control Reporting of Issues #276

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
The tool noto_lint.py should have a system to control the reporting of issues 
and to not dump spurious errors and warnings.

Original issue reported on code.google.com by stua...@google.com on 28 Feb 2015 at 12:49

GoogleCodeExporter commented 9 years ago
The linter takes --extrema_threshold, but still prints out warning messages for 
non-zero extrema violations that are under the threshold. But we want the 
linter to be mostly quiet, about warnings. So the linter should suppress these 
messages and simply report that there were N warnings about extrema.

Also, since it appears we're going to accept a lot of these extrema violations, 
we should default the threshold to something like .75 just to get the noise out 
of the system.

Original comment by dougf...@google.com on 6 Mar 2015 at 5:52

GoogleCodeExporter commented 9 years ago
All extrema failures are important, because they impact fontcrunch's ability to 
optimize outlines. So the threshold argument isn't all that useful in practice. 
 Instead I'll add an option to suppress extrema error reporting for purposes of 
pruning the lint output. And leave the default to report.

Original comment by dougf...@google.com on 6 Mar 2015 at 6:52