search

okigan / awscurl

curl-like access to AWS resources with AWS Signature Version 4 request signing.
MIT License
737 stars 91 forks source link

Drop python2 support #105

Closed jesusch closed 3 years ago

jesusch commented 3 years ago

With Python2 being EOL this could be pulled

okigan commented 3 years ago

Thanks! I thinks it’s worthwhile to move to it, but still keep in the CI loop.

jesusch commented 3 years ago

python -m venv venv includes the venv module and passes venv as argument that's the folder to be created (could be .venv, env, .env)

Am Mi., 3. März 2021 um 17:59 Uhr schrieb Igor Okulist < notifications@github.com>:

@okigan commented on this pull request.

In ci.sh https://github.com/okigan/awscurl/pull/105#discussion_r586774276:

@@ -1,6 +1,6 @@

!/usr/bin/env bash

-virtualenv venv -p python2.7 +python3 -m venv venv

I dont have enough context here: why venv is twice? (as module and command?)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/okigan/awscurl/pull/105#pullrequestreview-603340076, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASA3LRGB6KOCDVRLNADANTTB2PJ3ANCNFSM4YRGKZEA .

-- Mit freundlich Grüßen / Kind regards / Grato

Björn Boschman

okigan commented 3 years ago

I've returned testing of python 2.7 but kept your commits for migrating to python3 in the docker: https://github.com/okigan/awscurl/pull/109. Thanks!