Soften upper bound on urllib3?

[markus1189]

Is the upper bound on urllib3 necessary?

https://github.com/okigan/awscurl/blob/01cb53c86aba8f655720408f0736cebaa22b011d/setup.py#L24

I built it locally using nixpkgs which has 1.25.3 using a custom patch and it seems to work fine, but I am not a python developer at all :)

[okigan]

There were some issues on security, but higher ones had some compatibility issue - but I’d love to move up to higher version.

On Aug 8, 2019, at 1:09 PM, Markus Hauck notifications@github.com wrote:

Is the upper bound on urllib3 necessary?

https://github.com/okigan/awscurl/blob/01cb53c86aba8f655720408f0736cebaa22b011d/setup.py#L24 I built it locally using nixpkgs which has 1.25.3 using a custom patch and it seems to work fine, but I am not a python developer at all :)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[tuan231195]

Is there any update on this?

[okigan]

i did not have a chance to fully follow up on this.

Here the build https://travis-ci.org/okigan/awscurl/jobs/599389543 that passes with no restrictions, but I think we need more unit test for this [secure] part.

Any idea how to test that code path (was a while a go 8))

On Thu, Oct 17, 2019 at 3:20 PM vdtn359 notifications@github.com wrote:

Is there any update on this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/okigan/awscurl/issues/67?email_source=notifications&email_token=AADUYXQBTIS2FJHBNT5HJ2LQPDQJNA5CNFSM4IKNFBYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBRWOGA#issuecomment-543385368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADUYXUOMEXAZFEICKP6MULQPDQJNANCNFSM4IKNFBYA .