okikio / bundlejs

An online tool to quickly bundle & minify your projects, while viewing the compressed gzip/brotli bundle size, all running locally on your browser.
https://bundlejs.com
MIT License
751 stars 13 forks source link

Why does bundle have error squiggles? #21

Closed styfle closed 2 years ago

styfle commented 2 years ago

Why does bundle show error squiggles for "Input", "Output" and "Console"?

Does this represent errors like in VS Code, or does it mean something else?

image

okikio commented 2 years ago

It's a stylistic design choice. I use it as an alternative to an underline. It really only counts as an error indicator is the squiggly lines are red.

styfle commented 2 years ago

I see. Why are those underlined?

okikio commented 2 years ago
  1. It looked cool.
  2. It helps indicate that you can click on the input and output buttons. Without the squiggly lines, the input and output buttons look like just random text that don't do anything.
g-plane commented 2 years ago

For me, it's confusing.

okikio commented 2 years ago

@g-plane Well I'm always looking for ways to improve clarity and reduce confusion, do you have any ideas as to how I could avoid it being confusing, e.g. should I remove the underline?

g-plane commented 2 years ago

Personally, underlines are OK, but I think they shouldn't be squiggles.

okikio commented 2 years ago

@styfle Do you feel the same?

styfle commented 2 years ago

Yes, I was confused too. Underlines would be better 👍

okikio commented 2 years ago

Ok, I'll change it

okikio commented 2 years ago

This should now be fixed, please tell me what you think.

g-plane commented 2 years ago

That looks good. :+1:

okikio commented 2 years ago

@g-plane Awesome 🎉. @styfle You're the one who created this issue, am I good to close it?

styfle commented 2 years ago

Looks much better, thanks!