[Bug] duplicate dependencies if two imports depend on the same package

[yellowsink]

I was using bundlejs recently to test the bundle sizes of a library I author, crossani.

I was testing the size of it with two addon packages (@crossani/spring and @crossani/flip), which both import crossani.

Bundlejs did not de-duplicate these imports of the same module, causing a bundle size larger than most real-world build tools would produce, in which one copy of the crossani package is bundled and used by both.

More generally:

• import "a";
• import "b";
• a imports c
• b imports c too
• c included in bundle twice

[okikio]

Hmm...This issue seems to be due to @crossani/flip and @crossani/spring using 2 different versions of crossani

• https://unpkg.com/browse/@crossani/spring@latest/package.json
• https://unpkg.com/browse/@crossani/flip@latest/package.json

[yellowsink]

Ah, that makes sense, my fault then - I should be using peer deps come to think of it...

Also strange that they don't have ^ - must be an issue with my monorepo setup or something.

[yellowsink]

Was on my end, after fixing package vers is deduping as necessary.

And in case anyone else with this occuring comes across this - make sure if you're using a pnpm monorepo that you are using workspace:^ not workspace^*

[okikio]

TIL, thanks for leaving that feedback