okikio / bundlejs

An online tool to quickly bundle & minify your projects, while viewing the compressed gzip/brotli bundle size, all running locally on your browser.
https://bundlejs.com
MIT License
797 stars 15 forks source link

Possible badge caching issue #55

Closed thoughtspile closed 1 year ago

thoughtspile commented 1 year ago

I'm seeing suspicious "756 B" badges for various libraries when using export *, while the bundlejs console shows different results. looks like there might be some caching problem:

Here's a screenshot in case the cache gets busted:

Снимок экрана 2023-07-13 в 14 13 27

The actual size of fzy.js is close to 756 bytes, I suspect it might be returned for the other libraries.

yumauri commented 1 year ago

Initially I thought, that badge API doesn't support "external", but maybe I've stumbled at this issue as well

image
okikio commented 1 year ago

@yumauri Yeah, this issue is closely related to the cache being too strongly held for badges, I might just end up removing caching for badges, since it seems to be causing these issues

okikio commented 1 year ago

@thoughtspile @yumauri I've drastically reduced caching so caching should be less of an issue now. Please try it out to confirm that the issue has been fixed

yumauri commented 1 year ago

Looks like there are no more caching issues in my case 👍

thoughtspile commented 1 year ago

I'm not seeing any duplicates either, thanks a ton 💜

okikio commented 1 year ago

Awesome 👍🏽 I'll mark this issue as complete then