okirch / pcr-oracle

Predict TPM PCR values for future boot
GNU General Public License v2.0
7 stars 8 forks source link

Add support for systemd-cryptenroll JSON format #31

Closed aplanas closed 1 year ago

aplanas commented 1 year ago

@lcp @okirch can we start the review process?

I am currently extending the code to predict pcr12 and will sit on top of this set of changes.

lcp commented 1 year ago

okirch is the only maintainer of pcr-oracle. Let's wait for his review.

aplanas commented 1 year ago

@okirch @lcp maybe we can move the repo to the openSUSE project and share the burden of review / merge

aplanas commented 1 year ago

The last commit predict the PCR 12 value, reading the boot loader entries and sorting them.

okirch commented 1 year ago

Hi Alberto, I merged your changes now. Sorry for the delay, it seems that I had failed to enable notifications so I did not see your PR; I only saw one notification about a message from you during the weekend. Sorry about this

One minor request: could you update the manpage to describe the new --policy-format parameter, please?

aplanas commented 1 year ago

could you update the manpage to describe the new --policy-format parameter, please?

Yes. I will prepare a PR