search

okirch / pcr-oracle

Predict TPM PCR values for future boot
GNU General Public License v2.0
7 stars 8 forks source link

Use different IDs for loader entries #34

Closed aplanas closed 1 year ago

okirch commented 1 year ago 
if (!(fp = fopen("/etc/kernel/entry-token", "r"))) {
    warning("Cannot open /etc/machine_id: %m\n");

The file name in the message does not match what you're trying to open.

On systems that do not have /etc/kernel/entry-token, this will always trigger a warning. Is this desirable?

aplanas commented 1 year ago

The file name in the message does not match what you're trying to open.

Ouch. Fixed!

On systems that do not have /etc/kernel/entry-token, this will always trigger a warning. Is this desirable?

No. You are right. The expectation is that for sd-boot you will have it, but there is no guarantee. Downgraded to debug. Good point.

okirch commented 1 year ago

Thanks, I merged the PR now. Please note that I applied two small warning fixes on top and pushed them to the main branch, so please make sure you pull before you continue :-)