okitan / capybara-json

60 stars 23 forks source link

Minimal changes for Capybara 2.x #7

Closed gkellogg closed 11 years ago

gkellogg commented 11 years ago

I was able to address enough to allow the gem to be used with Capybara 2.0.1, but the spec structure has changed enough that I wasn't able to get them working.

Basically, added Driver#needs_server? (default false), and refactored HTTPClientJson::Driver#process to not depend on the now missing Capybara::Server#url method.

okitan commented 11 years ago

Thank you gkellogg.

I've also understood the minimal change for Capybara 2.x, but I was discouraged by the change of specs provided by capybara :(

I'll try a beta release after merging your pull-req tonight ( in JP timezone).

gkellogg commented 11 years ago

Thanks @okitan!