search

okize / hubot-frinkiac

Hubot plugin for Simpson's search engine Frinkiac
MIT License
16 stars 7 forks source link

Also respond to 'simpsons me' #3

Closed tabacco closed 8 years ago

tabacco commented 8 years ago

The "[action] me" phrasing is more consistent with other hubot scripts (and is also less stuff to type if you're lazy, like me)

okize commented 8 years ago

@tabacco I considered doing this but I was worried that there could be a conflict with existing simpsons-themed hubot plugins.

I would personally prefer this but let me do a little due diligence before merging this PR.

tabacco commented 8 years ago

Hmm... Maybe a shorter version like 'frink me'?

okize commented 8 years ago

So, these are the only two hubot plugins I've found (and they appear to be the same plugin):

The command there is hubot simpsons <quote | image> so I don't think this PR will conflict.

Nonetheless I'll bump the major version for this and if there ends up being a conflict somewhere the 1.x version could still be used.

okize commented 8 years ago

Published this PR in v2.0.0