Fix FAQ fragment too long mobile

okkur / syna

Highly customizable open source theme for Hugo based static websites

https://syna.okkur.org/demo/

Apache License 2.0

251 stars 134 forks source link

Fix FAQ fragment too long mobile #673

Closed ishchow closed 4 years ago

ishchow commented 4 years ago

What this PR does / why we need it: This PR removes a single CSS property in _faq.scss to fix an issue where the FAQ cards extend beyond the screen in mobile.

fixes #562

Special notes for your reviewer:

Release note:

Fix FAQ card width overflow on mobile

ghost commented 4 years ago

DeepCode's analysis on #f177ce found:

:x: 0 critical issues. :warning: 0 warnings and 0 minor issues. :heavy_check_mark: 0 issues were fixed.

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

:relaxed: If you want to provide feedback on our bot, here is how to contact us.

ishchow commented 4 years ago

I edited exampleSite/content/fragments/faq/faq/question1.md to make the question longer to show the change in effect. But I ended up not pushing the changes to the .md file since it wasn't necessary to fix the issue.

Before this PR on syna/master (1f21cd6fa3399d59d43fe89196d274a249f9ec43): syna-before-change

After this PR: syna-after-change

stp-ip commented 4 years ago

Thanks for the fix. Don't think there is any reason to keep the nowrap, so happy to merge once @mpourismaiel agrees.

Happy holidays.

ishchow commented 4 years ago

Thank you guys for the quick review! Happy new year!