search

okkur / syna

Highly customizable open source theme for Hugo based static websites
https://syna.okkur.org/demo/
Apache License 2.0
252 stars 134 forks source link

Add eslint and prettier for js files #699

Closed mpourismaiel closed 4 years ago

mpourismaiel commented 4 years ago

What this PR does / why we need it: Added linter and fixer for JS files

The configuration uses airbnb base config which is the closest to our style and prettier cleans up the code and doesn't interfere with airbnb's linting rules.

Which issue this PR fixes: fixes #698

ghost commented 4 years ago

Congratulations :beers:. DeepCode analyzed your code in 0.494 seconds and we found no issues. Enjoy a moment of no bugs :sunny:.

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

:relaxed: If you want to provide feedback on our bot, here is how to contact us.

stp-ip commented 4 years ago

Cypress failing ;)

mpourismaiel commented 4 years ago

We have to add some dependencies for cypress. Seems like Github's container is missing some packages that need to be installed manually. I'll read about how we can do so, but I guess we need a container of our own for it. https://docs.cypress.io/guides/guides/continuous-integration.html#Advanced-setup

stp-ip commented 4 years ago

Sounds fun ^^