search

okkur / syna

Highly customizable open source theme for Hugo based static websites
https://syna.okkur.org/demo/
Apache License 2.0
250 stars 133 forks source link

Fix image size in items fragments' columns #794

Closed mpourismaiel closed 4 years ago

mpourismaiel commented 4 years ago

What this PR does / why we need it: This is the best fix I could come up with. I really can't understand why flexbox behaved the way it did. With display: grid it was easier to fix the issue and as far as I can see the results are the same as they were when using display: flex.

Which issue this PR fixes: fixes #717

Special notes for your reviewer:

Release note:

- items: Fix overflowing image issue
stp-ip commented 4 years ago

This is probably harder to test as this is mainly visual. Any ideas? Manual test page or just leave it without a test? Besides the test. lgtm

mpourismaiel commented 4 years ago

I'm not really sure how to test it. I can't think of a way to create an automated test for it. A dev page might be a good idea but since writing tests for helpers I'm thinking of automating testing for other dev pages and don't like the idea of going through dev pages every now and then to make sure stuff works. We can create a dev page for now, it's better than nothing. If you don't have any suggestions we can create them and go ahead with merging the PR with dev page in it.

stp-ip commented 4 years ago

Ok let's go with the dev page only and see, if we can later automate visual and function testing on those "manual" pages. in the future. Thanks for working through ideas on tests.

mpourismaiel commented 4 years ago

@stp-ip Alright I created the dev page as well. Will think on how to automate the verification process.