search

okkur / syna

Highly customizable open source theme for Hugo based static websites
https://syna.okkur.org/demo/
Apache License 2.0
250 stars 133 forks source link

Fix postcss issues #816

Closed mpourismaiel closed 3 years ago

mpourismaiel commented 4 years ago

What this PR does / why we need it: Disable postcss asset pipes by default, it requires postcss variable to be set to true in site's Params config.

Which issue this PR fixes: fixes #813

Special notes for your reviewer:

Release note:

- Fix issue preventing site build when `postcss-cli` is not installed
stp-ip commented 4 years ago

Rerunning the test.

stp-ip commented 4 years ago

Interesting. We are running into the issue we want to fix in the tests. Did you run the tests locally as well?

mpourismaiel commented 4 years ago

I'm not really sure what's happening. Hugo builds and runs development server in all conditions. Production and development both work without postcss = true and they fail if postcss = true is set and postcss is not installed. But they will run with that parameter set, if postcss is installed.

In the test environment, cypress is not running since Hugo is failing and I can't figure out why that's happening. I'd appreciate any ideas or solutions.

stp-ip commented 4 years ago

Haven't figured out what's wrong here. Will take another stab at it once time permits.