Closed fjtc closed 2 years ago
Sidenote: I will squash merge this so it is a clean single commit.
One thing that might be a nice option is using git -p
and then restructure a PR into the commit steps you feel are worthwhile information. Say in this case adding the icons to the button fragment could be one, the next could be the usage of button within the nav and the last translation additions for example.
Thanks for the suggestions. As a new Hugo user, your suggestions and guidance are invaluable to us. I'm pretty sure we will contribute more to the project as we found Syna a perfect match to our needs.
I'm planning to send another patch soon with some enhancements we made to the button fragment. I noticed that we sent a partial implementation of it without the proper documentation.
Thanks to keep such a nice theme open for everyone to use.
What this PR does / why we need it:
Implements the features describe in the issue #862 by adding any number of buttons just like
repo_button
. This is an example of what this new feature can do:It replaces the previous PR #863 with the adjusts suggested by @stp-ip:
repo_button
, so it will not break backward compatibility;This patch also includes a new parameter
repo_button.no_text
that allows it to be used with no text at all. This parameter has been added to make it easier to display therepo_button
with the icon centered inside the button.Special notes for your reviewer:
Both the template and the documentation were updated to fully display the capabilities of this patch.
Release note: