search

oklas / react-app-alias

:label: Alias and multiple src directory for craco or rewired create-react-app
MIT License
173 stars 18 forks source link

fix: file alias check added for aliasMapForJest util #76 #77

Closed indatawetrust closed 2 years ago

indatawetrust commented 2 years ago

hi @oklas, do you have any comment for this pr?

oklas commented 2 years ago

Yes, I suggested to use some way to check for directory (see previous comment) instead of checking that file has extension. Directory also may have extension.

oklas commented 2 years ago

@AlanBlanchetNeovision, take a look at this. May be you can apply review suggestion to make it ready to merge.